Difference between revisions of "RPR-Debugging"

From "A B C"
Jump to navigation Jump to search
m
m
 
(2 intermediate revisions by the same user not shown)
Line 1: Line 1:
 
<div id="ABC">
 
<div id="ABC">
<div style="padding:5px; border:1px solid #000000; background-color:#f4d7b7; font-size:300%; font-weight:400; color: #000000; width:100%;">
+
<div style="padding:5px; border:1px solid #000000; background-color:#b3dbce; font-size:300%; font-weight:400; color: #000000; width:100%;">
 
Debugging R
 
Debugging R
<div style="padding:5px; margin-top:20px; margin-bottom:10px; background-color:#f4d7b7; font-size:30%; font-weight:200; color: #000000; ">
+
<div style="padding:5px; margin-top:20px; margin-bottom:10px; background-color:#b3dbce; font-size:30%; font-weight:200; color: #000000; ">
 
(Debugging with RStudio; the browser(), debug() and debugonce() commands; setting conditional breakpoints)
 
(Debugging with RStudio; the browser(), debug() and debugonce() commands; setting conditional breakpoints)
 
</div>
 
</div>
Line 10: Line 10:
  
  
<div style="padding:5px; border:1px solid #000000; background-color:#f4d7b733; font-size:85%;">
+
<div style="padding:5px; border:1px solid #000000; background-color:#b3dbce33; font-size:85%;">
 
<div style="font-size:118%;">
 
<div style="font-size:118%;">
 
<b>Abstract:</b><br />
 
<b>Abstract:</b><br />
Line 41: Line 41:
 
<b>Deliverables:</b><br />
 
<b>Deliverables:</b><br />
 
<section begin=deliverables />
 
<section begin=deliverables />
<!-- included from "./data/ABC-unit_components.txt", section: "deliverables-time_management" -->
 
 
<li><b>Time management</b>: Before you begin, estimate how long it will take you to complete this unit. Then, record in your course journal: the number of hours you estimated, the number of hours you worked on the unit, and the amount of time that passed between start and completion of this unit.</li>
 
<li><b>Time management</b>: Before you begin, estimate how long it will take you to complete this unit. Then, record in your course journal: the number of hours you estimated, the number of hours you worked on the unit, and the amount of time that passed between start and completion of this unit.</li>
<!-- included from "./data/ABC-unit_components.txt", section: "deliverables-journal" -->
 
 
<li><b>Journal</b>: Document your progress in your [[FND-Journal|Course Journal]]. Some tasks may ask you to include specific items in your journal. Don't overlook these.</li>
 
<li><b>Journal</b>: Document your progress in your [[FND-Journal|Course Journal]]. Some tasks may ask you to include specific items in your journal. Don't overlook these.</li>
<!-- included from "./data/ABC-unit_components.txt", section: "deliverables-insights" -->
 
 
<li><b>Insights</b>: If you find something particularly noteworthy about this unit, make a note in your [[ABC-Insights|'''insights!''' page]].</li>
 
<li><b>Insights</b>: If you find something particularly noteworthy about this unit, make a note in your [[ABC-Insights|'''insights!''' page]].</li>
 
<section end=deliverables />
 
<section end=deliverables />
Line 52: Line 49:
 
<section begin=prerequisites />
 
<section begin=prerequisites />
 
<b>Prerequisites:</b><br />
 
<b>Prerequisites:</b><br />
<!-- included from "./data/ABC-unit_components.txt", section: "notes-prerequisites" -->
 
 
This unit builds on material covered in the following prerequisite units:<br />
 
This unit builds on material covered in the following prerequisite units:<br />
 
*[[RPR-Introduction|RPR-Introduction (Introduction to R)]]
 
*[[RPR-Introduction|RPR-Introduction (Introduction to R)]]
Line 62: Line 58:
  
  
{{REVISE}}
 
  
 
{{Smallvspace}}
 
{{Smallvspace}}
Line 72: Line 67:
  
  
 +
=== Evaluation ===
 +
<b>Evaluation: NA</b><br />
 +
<div style="margin-left: 2rem;">This unit is not evaluated for course marks.</div>
 
== Contents ==
 
== Contents ==
<!-- included from "./components/RPR-Debugging.components.txt", section: "contents" -->
 
 
<!-- ToDo
 
<!-- ToDo
 
... develop additional example from http://r.789695.n4.nabble.com/Bug-td4743928.html#a4743929
 
... develop additional example from http://r.789695.n4.nabble.com/Bug-td4743928.html#a4743929
Line 79: Line 76:
 
-->
 
-->
  
When something goes wrong in your code, you need to look at intermediate values, as the code executes. Almost always sprinkling <code>print()</code> statements all over your code to retrieve such intermediate values is the least efficient way to isolate problems. But what is worse, you are temporarily modifying your code, and there is a significant risk that that this will create problems later.
+
When something goes wrong in your code, you need to look at intermediate values, as the code executes. Almost always sprinkling <code>print()</code> statements all over your code to retrieve such intermediate values is the least efficient way to isolate problems. Don't even be tempted: when you <code>print()</code> values you are temporarily modifying your code, and there is a significant risk that that this will create problems later.
  
 
Right from the beginning of your programming trajectory, you should make yourself familiar with '''R''''s debug functions.
 
Right from the beginning of your programming trajectory, you should make yourself familiar with '''R''''s debug functions.
  
* At first, you may need to pin down approximately where an error occurs. Read the error message carefully, or perhaps do print out some intermediate values from a loop.
+
* At first, you may need to pin down approximately where an error occurs. Read the error message carefully, or perhaps do print out some intermediate values from a loop. If there is an <span style="color:#CC0000;"><tt>Error: </tt></span>, RStudio will usually show you a traceback button that can tell you where the error occurred, and an option to re-run the code in debugger-mode.
* Make sure that it's your code that is at fault, not something else - Google for the error message to get a better idea about what is happeneing.
+
* Make sure that it's your code that is at fault, not something else - Google for the error message to get a better idea about what is happening.
 
* Debugging is done by entering a "browser" mode that allows you to step through a function.
 
* Debugging is done by entering a "browser" mode that allows you to step through a function.
 
* To enter this browser mode ...
 
* To enter this browser mode ...
** Call <code>debug(''function'')</code>. When <code>''function()''</code> is next executed, '''R''' will enter the browser mode. Call <code>undebug(''function'')</code> to clear the debugging flag on your function, or you can use the <code>debugonce(''function'')</code>, which will put the function into browser mode only at the next execution. Note that you don't have to set the debug flag at your top-level function, it could just as well be set on a funcytion that is called by a function which is called by the function that you call when the error occurs. Etc.
+
** Call <code>debug(''function'')</code>. When <code>''function()''</code> is next executed, '''R''' will enter the browser mode. Call <code>undebug(''function'')</code> to clear the debugging flag on your function.
** Alternatively insert a call to <code>browser()</code> into your function code to enter the browser mode. This sets a ''breakpoint'' into your function. You can also use  <code>if (''condition'') { browser() }</code> to enter the browser mode only when your function goes into a state of interest - e.g. a loop iteration variable right before the error occurs. This is called a "conditional breakpoint" (or "watchpoint""). A conditional breakpoint is especially useful if the problem occurs only rarely, in a particular context.
+
** Alternatively, you can use the <code>debugonce(''function'')</code>, which will put the function into browser mode only at the next execution. Note that you don't have to set the debug flag at your top-level function, it could just as well be set on a function that is called by a function which is called by the function that you call when the error occurs. Etc.
* It should go without saying that you need to discover that problems exist in the first place: study the [[RPR-Testing|Testing learning unit]] and test, test, and test again.
+
** Alternatively, open the function in the editor and '''click into the left margin'' (next to the line numbers). A red dot will appear there, and R will go into debug mode when that line of the code is reached. This sets a ''breakpoint'' into your function. You can also use  <code>if (''condition'') { browser() }</code> to enter the debugging mode only when your function goes into a state of interest - e.g. a loop iteration variable right before the error occurs. This is called a "conditional breakpoint" (or "watchpoint""). A conditional breakpoint is especially useful if the problem occurs only rarely, in a particular context, or late in a long iteration.
 +
* It should go without saying that you need to discover that problems exist in the first place: study the [[RPR-Unit_testing|Testing learning unit]] and test, test, and test again.
  
 
{{Vspace}}
 
{{Vspace}}
  
Here is an example: let's write a rollDice-function, i.e. a function that creates a vector of ''n'' integers between 1 and MAX - the number of faces on your die.
+
Here is an example: let's write a rollDice()-function, i.e. a function that creates a vector of ''n'' integers between 1 and MAX - the number of faces on your die. Open a new R script in RStudio, and copy/paste the following code. Execute, and try this.
  
<source lang="rsplus">
+
 
 +
<pre>
 
rollDice <- function(n = 1, min = 1, max = 6) {
 
rollDice <- function(n = 1, min = 1, max = 6) {
 
   # Simulating the roll of a fair die
 
   # Simulating the roll of a fair die
Line 113: Line 112:
 
   return(v)
 
   return(v)
 
}
 
}
</source>
+
</pre>
  
 
Lets try running this and see whether the distribution of numbers is fair...
 
Lets try running this and see whether the distribution of numbers is fair...
<source lang="rsplus">
+
<pre>
 
rollDice()
 
rollDice()
  
Line 125: Line 124:
 
table(x)
 
table(x)
 
hist(x, breaks = seq(0.5, 6.5, by = 1), xlim = c(0, 7), col = "#BBEEFF")
 
hist(x, breaks = seq(0.5, 6.5, by = 1), xlim = c(0, 7), col = "#BBEEFF")
</source>
+
</pre>
  
 
Problem: our "fair" die seems to return "fair" numbers - but it only returns values from 1 to 5. Why? Lets flag the function for debugging...
 
Problem: our "fair" die seems to return "fair" numbers - but it only returns values from 1 to 5. Why? Lets flag the function for debugging...
<source lang="rsplus">
+
<pre>
 
debug(rollDice)
 
debug(rollDice)
 
rollDice(10)
 
rollDice(10)
Line 181: Line 180:
 
Browse[2]> Q
 
Browse[2]> Q
 
undebug(rollDice)
 
undebug(rollDice)
</source>
+
</pre>
  
  
 
So lets change the function to round instead...
 
So lets change the function to round instead...
<source lang="rsplus">
+
<pre>
 
rollDice <- function(n = 1, min = 1, max = 6) {
 
rollDice <- function(n = 1, min = 1, max = 6) {
 
   # Simulating the roll of a fair die
 
   # Simulating the roll of a fair die
Line 212: Line 211:
 
table(x)  # Good - now all six numbers are there ...
 
table(x)  # Good - now all six numbers are there ...
 
hist(x, breaks = seq(0.5, 6.5, by = 1), xlim = c(0, 7), col = "#BBEEFF")
 
hist(x, breaks = seq(0.5, 6.5, by = 1), xlim = c(0, 7), col = "#BBEEFF")
</source>
+
</pre>
  
Ooooo! '''Wrong''' thinking. That's even worse - now all the values are there, but our function is no longer fair.
+
Ooooo! '''Wrong''' thinking. That's even worse - now all the values are there, but our function is no longer fair!
  
 
So we actually have to think a bit.
 
So we actually have to think a bit.
 
* <code>runif(n, min, max)</code> gives a uniform distribution of numbers. According to the documentation, this is in the interval (min, max), i.e. the actual limit values are not included.
 
* <code>runif(n, min, max)</code> gives a uniform distribution of numbers. According to the documentation, this is in the interval (min, max), i.e. the actual limit values are not included.
* <code>as.integer()</code> is not safe to use in any case, because it's behaviour is not explicit. Does it round? Does it truncate? Does it round up? We should have used <code>trunc()</code> or <code>round()</code> instead<ref>If you think you know how to round, have a look at the help page to the round function.</ref> for explicit, predictable behaviour.
+
* <code>as.integer()</code> is not safe to use in any case, because it's behaviour is not explicit. Does it round? Does it truncate? Does it round up? We should have used <code>trunc()</code>, <code>floor()</code>, <code>ceiling()</code>, or <code>round()</code> instead<ref>If you think you know how to round, have a look at the help page to the round function. I looked, I didn't.</ref> for explicit, predictable behaviour.
 
* The key problem is that we have created values for only 5 intervals, not six. So what we actually need to do is change the range, by adding 1 to max.
 
* The key problem is that we have created values for only 5 intervals, not six. So what we actually need to do is change the range, by adding 1 to max.
  
 
{{Smallvspace}}
 
{{Smallvspace}}
  
<source lang="rsplus">
+
<pre>
 
rollDice <- function(n = 1, min = 1, max = 6) {
 
rollDice <- function(n = 1, min = 1, max = 6) {
 
   # Simulating the roll of a fair die
 
   # Simulating the roll of a fair die
Line 250: Line 249:
 
table(x)
 
table(x)
 
hist(x, breaks = seq(0.5, 6.5, by = 1), xlim = c(0, 7), col = "#BBEEFF")
 
hist(x, breaks = seq(0.5, 6.5, by = 1), xlim = c(0, 7), col = "#BBEEFF")
</source>
+
</pre>
  
  
Line 262: Line 261:
 
{{Smallvspace}}
 
{{Smallvspace}}
  
<source lang="rsplus">
+
<pre>
 
set.seed(112358)
 
set.seed(112358)
 
x <- sample(1:6, 10000, replace=TRUE)
 
x <- sample(1:6, 10000, replace=TRUE)
Line 269: Line 268:
 
table(x)
 
table(x)
 
hist(x, breaks = seq(0.5, 6.5, by = 1), xlim = c(0, 7), col = "#BBEEFF")
 
hist(x, breaks = seq(0.5, 6.5, by = 1), xlim = c(0, 7), col = "#BBEEFF")
</source>
+
</pre>
  
 
Now if you look at the table() output, you see that these are the EXACT same numbers, because sample() does exactly the same as our rollDice() function. So why write our own? Because we might want to simulate more complex behaviour, like having a loaded die, or a memory effect, and writing the function ourselves gives us detailed control over the simulation.
 
Now if you look at the table() output, you see that these are the EXACT same numbers, because sample() does exactly the same as our rollDice() function. So why write our own? Because we might want to simulate more complex behaviour, like having a loaded die, or a memory effect, and writing the function ourselves gives us detailed control over the simulation.
  
 +
{{Vspace}}
 +
 +
== Further reading, links and resources ==
 
{{Smallvspace}}
 
{{Smallvspace}}
 
 
For more on RStudio's debugging interface, see [http://www.r-bloggers.com/visual-debugging-with-rstudio/ '''here'''] and [https://support.rstudio.com/hc/en-us/articles/205612627-Debugging-with-RStudio '''here'''].
 
For more on RStudio's debugging interface, see [http://www.r-bloggers.com/visual-debugging-with-rstudio/ '''here'''] and [https://support.rstudio.com/hc/en-us/articles/205612627-Debugging-with-RStudio '''here'''].
  
For a deeper excursion into '''R''' debugging, see [http://www.stats.uwo.ca/faculty/murdoch/software/debuggingR/debug.shtml this overview by Duncan Murdoch at UWO], and {{PDFlink|[http://www.biostat.jhsph.edu/~rpeng/docs/R-debug-tools.pdf Roger Peng's introduction to R debugging tools]}}.
+
For a deeper excursion into '''R''' debugging, see [https://journal.r-project.org/archive/2010-2/RJournal_2010-2_Murdoch.pdf this article by Duncan Murdoch at UWO], and {{PDFlink|[http://www.biostat.jhsph.edu/~rpeng/docs/R-debug-tools.pdf Roger Peng's introduction to R debugging tools]}}.
  
{{Vspace}}
 
 
== Self-evaluation ==
 
<!--
 
=== Question 1===
 
 
Question ...
 
 
<div class="toccolours mw-collapsible mw-collapsed" style="width:800px">
 
Answer ...
 
<div class="mw-collapsible-content">
 
Answer ...
 
 
</div>
 
  </div>
 
 
  {{Vspace}}
 
 
-->
 
 
== Notes ==
 
== Notes ==
<!-- included from "./components/RPR-Debugging.components.txt", section: "notes" -->
 
<!-- included from "./data/ABC-unit_components.txt", section: "notes" -->
 
 
<references />
 
<references />
== Further reading, links and resources ==
 
<!-- {{#pmid: 19957275}} -->
 
<!-- {{WWW|WWW_GMOD}} -->
 
<!-- <div class="reference-box">[http://www.ncbi.nlm.nih.gov]</div> -->
 
 
{{Vspace}}
 
 
 
<!-- included from "./data/ABC-unit_components.txt", section: "ABC-unit_ask" -->
 
 
----
 
  
 
{{Vspace}}
 
{{Vspace}}
  
<b>If in doubt, ask!</b> If anything about this learning unit is not clear to you, do not proceed blindly but ask for clarification. Post your question on the course mailing list: others are likely to have similar problems. Or send an email to your instructor.
 
 
----
 
 
{{Vspace}}
 
  
 
<div class="about">
 
<div class="about">
Line 330: Line 294:
 
:2017-08-05
 
:2017-08-05
 
<b>Modified:</b><br />
 
<b>Modified:</b><br />
:2019-01-07
+
:2020-09-25
 
<b>Version:</b><br />
 
<b>Version:</b><br />
:1.1
+
:1.2
 
<b>Version history:</b><br />
 
<b>Version history:</b><br />
 +
*1.2 2020 Maintenance
 
*1.1 Update set.seed() usage
 
*1.1 Update set.seed() usage
 
*1.0 First live version
 
*1.0 First live version
 
*0.1 First stub
 
*0.1 First stub
 
</div>
 
</div>
[[Category:ABC-units]]
 
<!-- included from "./data/ABC-unit_components.txt", section: "ABC-unit_footer" -->
 
  
 
{{CC-BY}}
 
{{CC-BY}}
  
 +
[[Category:ABC-units]]
 +
{{UNIT}}
 +
{{LIVE}}
 
</div>
 
</div>
 
<!-- [END] -->
 
<!-- [END] -->

Latest revision as of 12:38, 26 September 2020

Debugging R

(Debugging with RStudio; the browser(), debug() and debugonce() commands; setting conditional breakpoints)


 


Abstract:

Working effectively with your IDE's debugging tools is a prerequisite for efficient software development.


Objectives:
This unit will ...

  • ... introduce the R "Browser", the in-built debugging tool;
  • ... demonstrate debugging a function.

Outcomes:
After working through this unit you ...

  • ... can invoke the debugger on a function once or multiple times;
  • ... can step through code line by line, and examine the values of variables as you are doing so;
  • ... are familar with "conditional breakpoints" and know how to set them;
  • ... can confidently debug your own functions.

Deliverables:

  • Time management: Before you begin, estimate how long it will take you to complete this unit. Then, record in your course journal: the number of hours you estimated, the number of hours you worked on the unit, and the amount of time that passed between start and completion of this unit.
  • Journal: Document your progress in your Course Journal. Some tasks may ask you to include specific items in your journal. Don't overlook these.
  • Insights: If you find something particularly noteworthy about this unit, make a note in your insights! page.

  • Prerequisites:
    This unit builds on material covered in the following prerequisite units:


     



     



     


    Evaluation

    Evaluation: NA

    This unit is not evaluated for course marks.

    Contents

    When something goes wrong in your code, you need to look at intermediate values, as the code executes. Almost always sprinkling print() statements all over your code to retrieve such intermediate values is the least efficient way to isolate problems. Don't even be tempted: when you print() values you are temporarily modifying your code, and there is a significant risk that that this will create problems later.

    Right from the beginning of your programming trajectory, you should make yourself familiar with R's debug functions.

    • At first, you may need to pin down approximately where an error occurs. Read the error message carefully, or perhaps do print out some intermediate values from a loop. If there is an Error: , RStudio will usually show you a traceback button that can tell you where the error occurred, and an option to re-run the code in debugger-mode.
    • Make sure that it's your code that is at fault, not something else - Google for the error message to get a better idea about what is happening.
    • Debugging is done by entering a "browser" mode that allows you to step through a function.
    • To enter this browser mode ...
      • Call debug(function). When function() is next executed, R will enter the browser mode. Call undebug(function) to clear the debugging flag on your function.
      • Alternatively, you can use the debugonce(function), which will put the function into browser mode only at the next execution. Note that you don't have to set the debug flag at your top-level function, it could just as well be set on a function that is called by a function which is called by the function that you call when the error occurs. Etc.
      • Alternatively, open the function in the editor and 'click into the left margin (next to the line numbers). A red dot will appear there, and R will go into debug mode when that line of the code is reached. This sets a breakpoint into your function. You can also use if (condition) { browser() } to enter the debugging mode only when your function goes into a state of interest - e.g. a loop iteration variable right before the error occurs. This is called a "conditional breakpoint" (or "watchpoint""). A conditional breakpoint is especially useful if the problem occurs only rarely, in a particular context, or late in a long iteration.
    • It should go without saying that you need to discover that problems exist in the first place: study the Testing learning unit and test, test, and test again.


     

    Here is an example: let's write a rollDice()-function, i.e. a function that creates a vector of n integers between 1 and MAX - the number of faces on your die. Open a new R script in RStudio, and copy/paste the following code. Execute, and try this.


    rollDice <- function(n = 1, min = 1, max = 6) {
      # Simulating the roll of a fair die
      # Parameters:
      #    n    numeric  the number of rolls that are returned
      #    min  numeric  the minimum value returned
      #    max  numeric  the maximum value returned
      # Value
      #    Integer vector of length n containing the values
    
      v <- integer(n)
      for (i in 1:n) {
        x <- runif(1, min, max)
        x <- as.integer(x)
        v[i] <- x
      }
      return(v)
    }
    

    Lets try running this and see whether the distribution of numbers is fair...

    rollDice()
    
    set.seed(112358)
    x <- rollDice(10000)
    set.seed(NULL)
    
    table(x)
    hist(x, breaks = seq(0.5, 6.5, by = 1), xlim = c(0, 7), col = "#BBEEFF")
    

    Problem: our "fair" die seems to return "fair" numbers - but it only returns values from 1 to 5. Why? Lets flag the function for debugging...

    debug(rollDice)
    rollDice(10)
    
    # We switch to the browser interface. You can use the icons to go through the
    # code step by step, or execute more of the code. You can also step into the
    # next function, if one is being called, or step over it (by default). The
    # current expression is highlighted in the code pane.
    
    > debug(rollDice)
    > rollDice(10)
    debugging in: rollDice(10)
    debug at #1: {
        v <- integer(n)
        for (i in 1:n) {
            x <- runif(1, min, max)
            x <- as.integer(x)
            v[i] <- x
        }
        return(v)
    }
    Browse[2]>
    debug at #10: v <- integer(n)
    Browse[2]>
    debug at #11: for (i in 1:n) {
        x <- runif(1, min, max)
        x <- as.integer(x)
        v[i] <- x
    }
    Browse[2]>
    debug at #12: x <- runif(1, min, max)
    Browse[2]>
    debug at #13: x <- as.integer(x)
    Browse[2]>
    
    # Typing a variable name allows us to examine its current value:
    
    Browse[2]> x
    [1] 4.706351
    
    # Note that as.integer() hasn't been called yet. The Browser shows you the
    # next statement or block it will execute.
    
    Browse[2]>
    debug at #6: v[i] <- x
    Browse[2]>x
    debug at #4: x <- runif(1, min = MIN, max = MAX)
    Browse[2]> v
    [1] 4      # Aha: as.integer() truncates values! So all 5.something values
               # get turned into 5 and no 6 is ever returned. So, shall we round()
               # instead?
    Browse[2]> Q
    undebug(rollDice)
    


    So lets change the function to round instead...

    rollDice <- function(n = 1, min = 1, max = 6) {
      # Simulating the roll of a fair die
      # Parameters:
      #    n    numeric  the number of rolls that are returned
      #    min  numeric  the minimum value returned
      #    max  numeric  the maximum value returned
      # Value
      #    Integer vector of length n containing the values
    
      v <- integer(n)
      for (i in 1:n) {
        x <- runif(1, min, max)
        x <- round(x)     # <<<- changed to round() from as.integer()
        v[i] <- x
      }
      return(v)
    }
    
    rollDice()
    
    set.seed(112358)
    x <- rollDice(10000)
    set.seed(NULL)
    
    table(x)   # Good - now all six numbers are there ...
    hist(x, breaks = seq(0.5, 6.5, by = 1), xlim = c(0, 7), col = "#BBEEFF")
    

    Ooooo! Wrong thinking. That's even worse - now all the values are there, but our function is no longer fair!

    So we actually have to think a bit.

    • runif(n, min, max) gives a uniform distribution of numbers. According to the documentation, this is in the interval (min, max), i.e. the actual limit values are not included.
    • as.integer() is not safe to use in any case, because it's behaviour is not explicit. Does it round? Does it truncate? Does it round up? We should have used trunc(), floor(), ceiling(), or round() instead[1] for explicit, predictable behaviour.
    • The key problem is that we have created values for only 5 intervals, not six. So what we actually need to do is change the range, by adding 1 to max.


     
    rollDice <- function(n = 1, min = 1, max = 6) {
      # Simulating the roll of a fair die
      # Parameters:
      #    n    numeric  the number of rolls that are returned
      #    min  numeric  the minimum value returned
      #    max  numeric  the maximum value returned
      # Value
      #    Integer vector of length n containing the values
    
      v <- integer(n)
      for (i in 1:n) {
        x <- runif(1, min, max + 1) # <<<- increase max by one to give correct number of intervals
        x <- trunc(x)               # <<<- changed to trunc() from as.integer()
        v[i] <- x
      }
      return(v)
    }
    
    rollDice()
    
    set.seed(112358)
    x <- rollDice(10000)
    set.seed(NULL)
    
    table(x)
    hist(x, breaks = seq(0.5, 6.5, by = 1), xlim = c(0, 7), col = "#BBEEFF")
    


    Now the output looks correct.


     
    Disclaimer!
    A base R function exists that does the same thing: sample()


     
    set.seed(112358)
    x <- sample(1:6, 10000, replace=TRUE)
    set.seed(NULL)
    
    table(x)
    hist(x, breaks = seq(0.5, 6.5, by = 1), xlim = c(0, 7), col = "#BBEEFF")
    

    Now if you look at the table() output, you see that these are the EXACT same numbers, because sample() does exactly the same as our rollDice() function. So why write our own? Because we might want to simulate more complex behaviour, like having a loaded die, or a memory effect, and writing the function ourselves gives us detailed control over the simulation.


     

    Further reading, links and resources

     

    For more on RStudio's debugging interface, see here and here.

    For a deeper excursion into R debugging, see this article by Duncan Murdoch at UWO, and Roger Peng's introduction to R debugging tools.

    Notes

    1. If you think you know how to round, have a look at the help page to the round function. I looked, I didn't.


     


    About ...
     
    Author:

    Boris Steipe <boris.steipe@utoronto.ca>

    Created:

    2017-08-05

    Modified:

    2020-09-25

    Version:

    1.2

    Version history:

    • 1.2 2020 Maintenance
    • 1.1 Update set.seed() usage
    • 1.0 First live version
    • 0.1 First stub

    CreativeCommonsBy.png This copyrighted material is licensed under a Creative Commons Attribution 4.0 International License. Follow the link to learn more.